Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Remove EXIF information when uploading images, Ignore spaces on both sides of an URL, Ignore case when searching an article #1887

Closed
wants to merge 10 commits into from

Conversation

SladeGranger
Copy link

What this PR does?

Fix #1720
上传图片时去除图片EXIF敏感信息,仅保留Orientation字段。同时修复本地储存时自动生成的Thumbnail图片方向有时不对的问题。

Fix #1850
忽略附件设置中url相关内容前后的空格

Fix #1879
搜索文章时大小写不敏感

Ignore case when searching articles
Remove EXIF information when uploading images
Ignore spaces on both sides of the possible part of an URL
Remove EXIF information when uploading images
Ignore spaces on both sides of an URL
Remove EXIF information when uploading images
Remove EXIF information when uploading images
Ignore spaces on both sides of an URL
Remove EXIF information when uploading images
Fix a problem: Generated thumbnail may have a wrong direction
Remove EXIF information when uploading images
Ignore spaces on both sides of an URL
Remove EXIF information when uploading images
Ignore spaces on both sides of an URL
Remove EXIF information when uploading images
Ignore spaces on both sides of an URL
Remove EXIF information when uploading images
Ignore spaces on both sides of an URL
@CLAassistant
Copy link

CLAassistant commented Apr 24, 2022

CLA assistant check
All committers have signed the CLA.

@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen April 24, 2022 01:32
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Apr 24, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign johnniang after the PR has been reviewed.
You can assign the PR to them by writing /assign @johnniang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SladeGranger SladeGranger changed the title Cs304 feat:Remove EXIF information when uploading images, Ignore spaces on both sides of an URL, Ignore case when searching an article Apr 24, 2022
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

几点问题:

  1. 一个 PR 仅针对一个问题或者特性。
  2. 在提交 PR 前,先在原 issue 进行讨论实现方案。

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果能够有一些简单的单元测试就好了 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants